-
Notifications
You must be signed in to change notification settings - Fork 159
Enable remote debugging with delve #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable remote debugging with delve #742
Conversation
Hi @mauriciopoppe. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Oops, didn't see it was still a draft. |
01c81f5
to
5c2696b
Compare
@mattcary I think this is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
Just a few nits.
39eb8a9
to
ca3e20f
Compare
/lgtm |
/hold cancel |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Enables remote debugging of the pd-csi-driver controller running on a cluster inside a container,
summary of changes:
Dockerfile.debug
file, this file used only in linux nodes includes the delve binary and the source code of the appnoauth-dev
, the overlay starts the PD CSI driver controller with delve in headless mode accepting connections in the port 2345Makefile
, to build the binaries in debug modeSteps to deploy the binaries:
make build-and-push-multi-arch-dev
2345
Does this PR introduce a user-facing change?: